fix: highlight the use of machine name for orgs help #326
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcresswell
previously requested changes
Jan 9, 2019
|
@robcresswell agree about the example, I had the same feeling. Question is how would we refer to that name if not by "machine name" ? |
|
I think filling out the text with an example should be enough. More bothered about clarity than pretty help output :) |
|
@robcresswell how does it read now? |
lili2311
approved these changes
Mar 14, 2019
lirantal
force-pushed
the
fix/help-for-orgs
branch
from
15766b2
to
c9f03f8
Compare
lirantal
force-pushed
the
fix/help-for-orgs
branch
from
08a23e3
to
7181063
Compare
|
🎉 This PR is included in version 1.136.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current help advises to use specify the org name but it isn't clear about the fact that you need to specify the "machine name" representation of the org name.
If I have an org called "Liran demo", it has a machine name of "liran-demo-123" associated with it and the latter is the one that should be provided to the CLI.